[mythtv-commits] Ticket #11625: Patch to initialize fd_set in MythSystemLegacyIOHandler ctor - fixes coverity 1028698

[MythTV]

#11625: Patch to initialize fd_set in MythSystemLegacyIOHandler ctor - fixes
coverity 1028698
-------------------------------------------------+-------------------------
 Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |           Type:  Patch -
   Status:  new                                  |  Bug Fix
Milestone:  unknown                              |       Priority:  minor
  Version:  Master Head                          |      Component:  MythTV
 Keywords:                                       |  - MythSystem
                                                 |       Severity:  medium
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------
 Static analysis detected that the fd_set was not being initialized in the
 ctor.  While correct from a static analysis POV, the structure was being
 initialized elsewhere before use.  To make static analysis happy,
 initialize the fd_set.

 Fixes coverity 1028698

 Note that coverity may not properly understand that the use of the
 provided FD_ZERO macro will properly initialize the structure since on
 some platforms (i.e. x86) the macro turns into inline assembly code.  In
 the case that adding the patch does not eliminate the coverity issue, one
 will need to manually acknowledge the defect.


 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/7323bf7a71b42f379f139b57524b82e1ff28d6bc

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/7323bf7a71b42f379f139b57524b82e1ff28d6bc.patch

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11625>
MythTV <http://www.mythtv.org>
MythTV Media Center