[mythtv-commits] Ticket #11610: Patch to check fcntl success in mythsystemunix.cpp - fixes coverity 1028691

MythTV noreply at mythtv.org
Tue Jun 18 21:35:42 UTC 2013


#11610: Patch to check fcntl success in mythsystemunix.cpp - fixes coverity 1028691
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  beirdo
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Bug Fix                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - MythSystem              |   Keywords:
     Severity:  medium                           |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Static analysis (coverity) detected that the system call fcntl in
 mythsystemunix.cpp did not check its return value.  This patch adds in
 that check.

 This patch also implements the more robust setting of the fd flags (get
 the current flags, or'ing in the NONBLOCK value, and then setting the
 flags).
 This is the "correct" way to set flags per the docs (even though in this
 case it is probably overkill).

 Fixes coverity 1028691

 github patch:
 https://github.com/garybuhrmaster/mythtv/commit/26472f379970d6be81c77e8d2f311dccfd25ad47

 github git-am patch:
 https://github.com/garybuhrmaster/mythtv/commit/26472f379970d6be81c77e8d2f311dccfd25ad47.patch

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11610>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list