[mythtv-commits] Ticket #11710: crashes when fast forwarding in a DVD

[MythTV]

#11710: crashes when fast forwarding in a DVD
----------------------------------+-----------------------------
 Reporter:  jyavenard             |          Owner:  stichnot
     Type:  Bug Report - General  |         Status:  assigned
 Priority:  critical              |      Milestone:  0.27
Component:  MythTV - General      |        Version:  Master Head
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------

Comment (by jyavenard):

 I'm not sure this shouldn't be instead:
 {{{
     if (IsWatchingInprogress() && position == (uint64_t)-1)
 }}}

 instead of:
 {{{
     if (player_ctx->recorder && position == (uint64_t)-1)
 }}}

 but as the test to check if player_ctx isn't consistently the same manner:
 sometimes the test is:
 if (islivetvcur || IsWatchingInprogress())
 sometimes it's:
 if (player_ctx->recorder)
 sometime it's:
 if (IsWatchingInprogress())
 or:
 if (!(livetv || (player_ctx->recorder &&
                      player_ctx->recorder->IsValidRecorder())))

 simply testing player_ctx->recorder prevent the crash, but would the
 behaviour be okay should it be:
 if (player_ctx->recorder && player_ctx->recorder->IsValidRecorder() &&
 position == (uint64_t)-1)

 leaving that up to you

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11710#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center