[mythtv-commits] Ticket #11636: (Speculative) patch to initialize member variables in ctor - sibling to ticket #11629
MythTV
noreply at mythtv.org
Mon Jul 1 01:17:37 UTC 2013
#11636: (Speculative) patch to initialize member variables in ctor - sibling to
ticket #11629
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Type: Patch -
Status: new | Bug Fix
Milestone: unknown | Priority: minor
Version: Master Head | Component: MythTV
Keywords: | - MythSystem
| Severity: medium
| Ticket locked: 0
-------------------------------------------------+-------------------------
In ticket #11629 there is attached a proposed patch
4dc18c79d3d3b1885b251318f404473c5e691c2a which initialized member
variables in mythsystemunix.cpp to fix a coverity issue. Do the same in
mythsystemwindows.cpp for consistency (and because if static analysis was
run on the windows source, it would likely report the same issue).
This is a speculative patch. My attempts at compiling in Windows have not
been successful. This patch looks correct, and is consistent with its
sibling for mythsystemunix.cpp. Nevertheless, it could be bad. If the
windows buildbot manages to be resurrected, and this patch is applied and
causes difficulties I am willing to assist in resolution.
github ref:
https://github.com/garybuhrmaster/mythtv/commit/77bed7bce0e492fc6b04f16b6c971191b679b88a
github git-am ref:
https://github.com/garybuhrmaster/mythtv/commit/77bed7bce0e492fc6b04f16b6c971191b679b88a.patch
--
Ticket URL: <http://code.mythtv.org/trac/ticket/11636>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list