[mythtv-commits] Ticket #10721: Mythmusic FLAC import fails with large number of files
MythTV
noreply at mythtv.org
Wed May 30 11:56:03 UTC 2012
#10721: Mythmusic FLAC import fails with large number of files
-------------------------------+-------------------------------------------
Reporter: mayfields@… | Owner: Stuart Morgan <smorgan@…>
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 0.25.1
Component: MythTV - General | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythmusic flac | Ticket locked: 0
metadata |
-------------------------------+-------------------------------------------
Comment (by Stuart Morgan <smorgan@…>):
In [changeset:6ce0af8ce480b7445ebbd198a008f6023d17d24e/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="6ce0af8ce480b7445ebbd198a008f6023d17d24e"
Fix file handle leaks in oggvorbis and wavpack tag readers. These, along
with one in the flac tag reader were caused when we stopped using an
instance of the Taglib::FileRef class to read the track length.
Taglib::FileRef would take ownership of the pointer and delete it when we
were done, now that we're not using Taglib::FileRef we're again
responsible for deleting the object which in turn closes the open file
handle. Refs #10721
(cherry picked from commit f46b168a87a609b4cc6834f32d392ebf83dfe89e)
}}}
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721#comment:8>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list