[mythtv-commits] Ticket #10778: getTagger holds file open after use

[MythTV]

#10778: getTagger holds file open after use
----------------------------------+----------------------------
 Reporter:  mayfields@…           |          Owner:
     Type:  Bug Report - General  |         Status:  new
 Priority:  minor                 |      Milestone:  unknown
Component:  Plugin - MythMusic    |        Version:  0.25-fixes
 Severity:  low                   |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+----------------------------

Comment (by mayfields@…):

 The tagger needs to have the file open. However, there are a couple of
 issues with this.

 The first is that when a flacvorbis tagger is returned, the ID3 tagger has
 the file open as the ID3 tag is checked first. This should be closed prior
 to returning the flacvorbis tagger.

 The second is that, once used for whatever purpose, the tagger is not
 closing the file. There needs to be a mechanism for the tagger to close
 the file.

 I will put a patch together that addresses both of these and attach, but
 it may not be the ideal solution as it will simply attempt to read
 metadata from a non-existent file by passing NULL as the filename which
 will fail in all cases but force the MetaIOID3 tagger to close the current
 file. This will likely lead to spurious errors about files not being able
 to be read, even though it is the intended behaviour.

 If there is a way to determine which class the tagger is then the
 preferred option would be to determine the class and only call
 tagger->read(NULL) if the class is MetaIOID3. This will fail without error
 as it checks the file extension.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10778#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center