[mythtv-commits] Ticket #10766: Music import fails due to open files not closed

MythTV noreply at mythtv.org
Wed May 30 04:13:46 UTC 2012

#10766: Music import fails due to open files not closed
 Reporter:  mayfields@…         |          Owner:  stuartm
     Type:  Patch - Bug Fix     |         Status:  accepted
 Priority:  major               |      Milestone:  0.25.1
Component:  Plugin - MythMusic  |        Version:  0.25-fixes
 Severity:  medium              |     Resolution:
 Keywords:                      |  Ticket locked:  0

Comment (by mayfields@…):

 OK, not what I thought.

 avfdecoder.cpp creates a new MetaIOID3 object, opens a file using it, but
 doesn't always return it. If it isn't returned, it should be deleted
 otherwise the file is kept open. Patch for avfdecoder.cpp attached.

 There is still one residual issue with the file scanner after the fixes
 for wav, ogg, and flac MetaIO classes, as well as avfdecoder.cpp.

 The file scanner tries to get album art from the tags, and this opens a
 file. This file is closed when the next file is scanned due to the way
 MetaIOID3 is implemented, but after the scan the last file stays held
 open. Perhaps a new ticket is in order for that as it doesn't prevent the
 scan completing like the other issues do (with large libraries).

Ticket URL: <http://code.mythtv.org/trac/ticket/10766#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center

More information about the mythtv-commits mailing list