[mythtv-commits] Ticket #10693: Fix passthrough case of mythtrancode running in fifo mode

MythTV noreply at mythtv.org
Sat May 5 10:06:20 UTC 2012

#10693: Fix passthrough case of mythtrancode running in fifo mode
 Reporter:  mythtv@…    |           Type:  Patch - Bug Fix
   Status:  new         |       Priority:  minor
Milestone:  unknown     |      Component:  MythTV - Mythtranscode
  Version:  0.25-fixes  |       Severity:  medium
 Keywords:              |  Ticket locked:  0
 See pull request: https://github.com/MythTV/mythtv/pull/20

 The new version of AudioRencodeBuffer requires the assumption that buflen
 == frames * byte_per_frame, which isn't true in passthrough mode, since
 the data is compressed. I've updated the code so that, at least in the
 case that m_audioFrameSize == 0, the number of frames is recorded
 separately from the buffer length, and used in further calculations. That
 fixes the fifo-mode case. Possibly other passthrough cases could be
 handled by changing the condition on which frames are used, but I don't
 understand enough of the surrounding code to be sure.

 I've also simplified AudioReencodeBuffer::addData. Now data is always
 placed in saveBuffer before moving to the buffer list. That simplifies the
 algorithm a lot without any loss in efficiency.

 Lastly I've changed one of the calls to cutter where 1 was being passed
 rather than the number of frames.

Ticket URL: <http://code.mythtv.org/trac/ticket/10693>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center

More information about the mythtv-commits mailing list