[mythtv-commits] Ticket #10677: Safely escape shell arguments

[MythTV]

#10677: Safely escape shell arguments
------------------------------+-----------------------------
 Reporter:  github@…          |          Owner:
     Type:  Patch - Bug Fix   |         Status:  closed
 Priority:  minor             |      Milestone:  unknown
Component:  MythTV - General  |        Version:  Master Head
 Severity:  medium            |     Resolution:  Won't Fix
 Keywords:                    |  Ticket locked:  0
------------------------------+-----------------------------

Comment (by github@…):

 The missing piece here seems to be the kMSNoRunShell flag. That would fix
 the issue so that clients can use !MythSystem safely.

 That flag is not documented, (see
 https://www.google.com/search?q=MythSystem+kMSNoRunShell). Of 63 uses of
 !MythSystem in the code, that flag is not used anywhere except for in
 !MetadataDownload.

 I could be wrong, but I got the feeling that you are confident that the
 system's current behavior is correct. So, I'm just curious, if this issue
 and issue #10680 are going to be closed, then which ticket tracks the
 adoption of kMSNoRunShell in the 26 other files that use it? On the other
 hand, if you decide that the shell escaping bugs ought to be addressed,
 then let's reopen this ticket and start making patches.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10677#comment:6>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center