[mythtv-commits] Ticket #10396: Periodical, short audio artifacts in one the channels when upmixing to 5.1

[MythTV]

#10396: Periodical, short audio artifacts in one the channels when upmixing to 5.1
------------------------------------------+--------------------------------
 Reporter:  blazej.lewcio@…               |          Owner:  jyavenard
     Type:  Bug Report - General          |         Status:  infoneeded_new
 Priority:  minor                         |      Milestone:  unknown
Component:  MythTV - Audio Output         |        Version:  Unspecified
 Severity:  medium                        |     Resolution:
 Keywords:  upmixing                      |  Ticket locked:  0
------------------------------------------+--------------------------------

Comment (by jyavenard):

 while it does make sense to reset, in effect it's not necessary as none of
 the encoder will effectively buffer any data

 I am fairly certain it wouldn't fix the issue the OP is seeing...

 If you actually had a closer look on what it is actually doing, it
 actually works that way:
 org_waud = waud = next position to write
 if (upmixing)
 {
    upmix and copy into org_waud and update it
    update number_of_frames_added
 }

 if (encoder)
 {
    // go back to beginning of new audio added:
    org_waud = waud
    encode number_of_frames_added
 }

 so where the upmixer write its data is irrelevant, the encoder will start
 from where the upmixer started.
 As the AC3 encoder will always produce a smaller output, there's no
 overlap of any kind.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10396#comment:28>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center