[mythtv-commits] Ticket #10396: Periodical, short audio artifacts in one the channels when upmixing to 5.1

[MythTV]

#10396: Periodical, short audio artifacts in one the channels when upmixing to 5.1
------------------------------------------+--------------------------------
 Reporter:  blazej.lewcio@…               |          Owner:  jyavenard
     Type:  Bug Report - General          |         Status:  infoneeded_new
 Priority:  minor                         |      Milestone:  unknown
Component:  MythTV - Audio Output         |        Version:  Unspecified
 Severity:  medium                        |     Resolution:
 Keywords:  upmixing                      |  Ticket locked:  0
------------------------------------------+--------------------------------

Comment (by jyavenard):

 Now that you mention that the AC3 encoder is in use. It all makes sense.
 And you're looking at a non-issue

 For a start, the encoder is re-created during each reconfigure..
 (Actually looks like there is a potential leak, the encoder isn't deleted
 if it already exists...)

 2nd, doing a reset of the encoder is useless. It will always exhaust all
 the data it has been provided after it exits. so by the time it's finished
 processing the data given in AddFrames, it is always empty

 3rd: It's perfectly okay for org_waud to not be a multiple of
 bytesperframe. The audio is upmixed within the ringbuffer only as
 temporary storage. It is immediately compressed as AC3 and bytesperframe
 there isn't 24 anymore, but 4. You'll find that all those values are
 multiples of 4 as expected

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10396#comment:25>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center