[mythtv-commits] mythtv branch master updated by jyavenard. v0.26-alpha-18-gc35c003

[Git Repo Owner]

The branch, master has been updated on the
mythtv repository by gitolite user jyavenard.
       via  c35c00385f781e6736026848d54d75ffa6006219 (commit)
      from  0a5d426a0c4ab4ac8791c9e87f8f44bf2e0b8514 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c35c00385f781e6736026848d54d75ffa6006219
Author:    Lawrence Rust <lvr at softsystem.co.uk> at Thu, 7 Jun 2012 11:52:29 +0200
Committer: Jean-Yves Avenard <jyavenard at mythtv.org> at Sat, 21 Jul 2012 21:40:51 +1000
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=c35c00385f781e6736026848d54d75ffa6006219

libmyth: Prevent an access violation by the ALSA library
In audiooutputalsa.cpp, AudioOutputALSA::GetALSADevices calls the
ALSA API snd_device_name_hint with a card index of -1 to obtain a list
of hints for all cards.  Unfortunately, with libasound.so.2.0 this API
can cause an access violation when the card index is -1.

Running with valgrind shows that snd_device_name_hint makes reference
to previously freed memory when the card index is -1.

This patch enumerates the cards using other ALSA APIs, thus avoiding
the SEGV.

Signed-off-by: Jean-Yves Avenard <jyavenard at mythtv.org>



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmyth/audio/audiooutputalsa.cpp |   52 +++++++++++++++++--------
 1 files changed, 35 insertions(+), 17 deletions(-)

--