[mythtv-commits] mythtv/fixes/0.24 commit: a99ab35f2 by Michael T. Dean (sphery)

MythTV noreply at mythtv.org
Fri Jan 20 21:04:15 UTC 2012


      Author:  Michael T. Dean <mdean at mythtv.org>
 Change Date:  2012-01-20T13:01:41-08:00
   Push Date:  2012/01/20 13:04:09 -0800
  Repository:  mythtv
      Branch:  fixes/0.24
New Revision:  a99ab35f2094c8d6c3b61751fe0eaec466d87cb0
   Changeset:  https://github.com/MythTV/mythtv/commit/a99ab35f2

Log:

Fix warnings in 1262 DB upgrade.

Fix warnings that can occur in the 1262 DB upgrade if any of the columns
being changed to varchar contain NULL values.

These warnings resulted in a DB upgrade failure for a at least one user,
but in attempting to reproduce the failure (with Qt4.6.2+MySQL5.1,
Qt4.6.2+MySQL5.5, Qt4.7.3+MySQL5.1, Qt4.8.0+MySQL5.1, and
Qt4.8.0+MySQL5.5), I was unsuccessful.  The only way I was able to cause
it to fail was with MySQL strict mode enabled
(sql_mode=STRICT_ALL_TABLES).  Note that many other parts of MythTV are
likely to fail with strict mode enabled, so it is recommended that users
do not enable strict mode.

Thanks to dchilton for reporting the issue, and to JK for helping to
troubleshoot.
(cherry picked from commit 96cf1cfcecae7a3ce7f27c2485bb0486f0bdff0b)

Modified:

   mythtv/libs/libmythtv/dbcheck.cpp



More information about the mythtv-commits mailing list