[mythtv-commits] Ticket #8598: Mytharchive fails when creating dvd iso

[MythTV]

#8598: Mytharchive fails when creating dvd iso
------------------------------------------+----------------------------
 Reporter:  nikolai@…                     |          Owner:  paulh
     Type:  defect                        |         Status:  closed
 Priority:  minor                         |      Milestone:  unknown
Component:  Plugin - MythArchive          |        Version:  0.23-fixes
 Severity:  medium                        |     Resolution:  invalid
 Keywords:  mytharchive iso create faile  |  Ticket locked:  0
------------------------------------------+----------------------------

Comment (by t.brackertz@…):

 That's exactly the case:


 {{{
 if path_M2VRequantiser[0] == "":

    fatalError("M2VRequantiser is not available to resize the files. Giving
 up!")
 }}}


 only tests if there is a path configured. It doesn't care if it's right or
 not. But apart from that there are a lot of other reasons for the
 requantization-process to fail. These aren't caught by this test, either.

 So as mentioned before my suggestion is to move the following part:

 {{{
 if result<>0:

  fatalError("Failed while running M2VRequantiser. Command was %s" %
 command)
 }}}
 At its current position it's completely useless because if the
 requantisation fails for any reason the script crashes before reaching the
 statement.

 Then the following part is obsolete and can be removed:
 {{{
 if path_M2VRequantiser[0] == "":

    fatalError("M2VRequantiser is not available to resize the files. Giving
 up!")
 }}}

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/8598#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center