[mythtv-commits] Ticket #9824: [PATCH] MythPlayer: Fix playback of dvb-s radio channels

MythTV noreply at mythtv.org
Thu Oct 13 08:24:32 UTC 2011

#9824: [PATCH] MythPlayer: Fix playback of dvb-s radio channels
 Reporter:  Lawrence Rust <lvr@…>                |          Owner:
     Type:  Patch - Bug Fix                      |         Status:  new
 Priority:  minor                                |      Milestone:  unknown
Component:  MythTV - General                     |        Version:
 Severity:  medium                               |  0.24-fixes
 Keywords:                                       |     Resolution:
                                                 |  Ticket locked:  0

Comment (by markk):

 Lawrence - I've just started looking at these patches.

 As a general observation (and this applies to various patches you've
 submitted, not just these), your patches are difficult to review because
 they contain various unnecessary and largely cosmetic changes that obscure
 what you are really trying to achieve. For example, converting locks to
 use QMutexLocker is fine but put them in a different patch.

 Given the potential impact of some of these changes, it would also be much
 appreciated if you explained what you are doing with various changes.

 I'd suggest you try and cut them down to what is absolutely needed.

Ticket URL: <http://code.mythtv.org/trac/ticket/9824#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center

More information about the mythtv-commits mailing list