[mythtv-commits] Ticket #9997: patch: Fix commercial flagging to return consistent results

MythTV noreply at mythtv.org
Sun Oct 9 16:16:43 UTC 2011

#9997: patch: Fix commercial flagging to return consistent results
 Reporter:  kevin@…                |          Owner:  markk
     Type:  Bug Report - General   |         Status:  closed
 Priority:  minor                  |      Milestone:  0.24.2
Component:  MythTV - Mythcommflag  |        Version:  0.24.1
 Severity:  medium                 |     Resolution:  Fixed
 Keywords:                         |  Ticket locked:  0
Changes (by mdean):

 * status:  assigned => closed
 * resolution:   => Fixed
 * milestone:  unknown => 0.24.2


 Fixed by f135d5d5e and backported to 0.24-fixes in cb01f3079a0:

 Fix MythPlayer::GetRawVideoFrame() for mythcommflag.

 Fix MythPlayer::GetRawVideoFrame() to return the correct frame number.
 This change fixes mythcommflag so that it will return consistent results
 across multiple runs.  It should also improve commercial detection
 accuracy, as the frame numbers identified by the different methods will
 actually be precise--allowing for better comparing the results of the
 different methods.

 Although this commit has my name for the signed-off line, I didn't do
 much.  Thanks to Kevin Ross for the debugging and the patch, to Taylor
 Ralph and Mark Kendall for actually reviewing the patch, and to all the
 users and devs who ran with the patch to test it (and saw greatly-improved
 commercial flagging results).

 Fixes #9997.

 Signed-off-by: Michael T. Dean <mdean at mythtv.org>

Ticket URL: <http://code.mythtv.org/trac/ticket/9997#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center

More information about the mythtv-commits mailing list