[mythtv-commits] Ticket #9625: Exiting near end of still-recording program results in no bookmark set

[MythTV]

#9625: Exiting near end of still-recording program results in no bookmark set
-------------------------------------------------+-------------------------
 Reporter:  John Veness <John.Veness.mythtv@…>   |          Owner:  mdean
     Type:  Bug Report - General                 |         Status:  closed
 Priority:  minor                                |      Milestone:  0.25
Component:  MythTV - General                     |        Version:
 Severity:  medium                               |  0.24-fixes
 Keywords:                                       |     Resolution:  fixed
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------
Changes (by Michael T. Dean):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Allow near-end bookmarks for in-progress recordings.

 When exiting in-progress recordings, what's now near the end may not be
 near the end later, so go ahead and set a bookmark (for those who have
 specified "Save position and exit"), so users don't lose their place.

 I didn't modify MythPlayer::SetWatched(), since I have a feeling quite a
 few users will watch in-progress recordings and exit after the end of
 the show, but before recording stops--in which case they have watched it
 and just want to be done with it (rather than have to manually mark it
 watched).  On the other hand, users who watch until they're caught up
 with current time then exit before the end of the show will likely come
 back to finish watching the recording sooner, rather than later (so it
 will be watched soon enough).  Alternatively, if the auto-detection does
 the wrong thing, they can choose to mark the show unwatched.

 Since we can't always do the right thing automatically, I'm trying to
 guess what's likely right for the most people.  That said, I have some
 projects in the works to improve both bookmark and watched handling.

 Fixes #9625.
  Changeset: 624c23c56d21ee2840aef24d9f447baa54eb7d84

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9625#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center