[mythtv-commits] Ticket #9268: [PATCH] mythvideo: fix win32 playback of dvd's and iso images

[MythTV]

#9268: [PATCH] mythvideo: fix win32 playback of dvd's and iso images
-------------------------------------------------+-------------------------
 Reporter:  Lawrence Rust <lvr@…>                |          Owner:  markk
     Type:  Patch - Bug Fix                      |         Status:
 Priority:  minor                                |  assigned
Component:  Ports - Windows                      |      Milestone:  unknown
 Severity:  medium                               |        Version:  Trunk
 Keywords:                                       |  Head
                                                 |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Github):

 Store the video aspect ratio in the video buffers.

 .. and use the buffer value to determine the video aspect ratio during
 playback.

 This has the principle (user) advantage of actually synchronising aspect
 ratio changes with the actual change in the video stream (rather than
 10-20 frames early).

 From a code perspective, this further reduces calls from the decoder
 thread into the player, which cause significant playback interruption
 with cpu based playback and introduces thread related issues for
 hardware graphics contexts.

 The 'video_codec_changed' parameter is removed from
 MythPlayer::SetVideoParams (it has not been used since XvMC was
 removed), keyframedistance is set separately and an aspect ratio change
 no longer triggers a video output change directly - only when the video
 frame is about to be displayed.

 Theoretically there is no reason to trigger SetVideoParams for a frame
 rate change either but xrandr/display res changes are triggered by a
 combination of changes in video size and frame rate.

 Ref #9268
  Branch:    master
  Changeset: 857d804b8f57cfff800bf22866ea60480fdfb697

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9268#comment:11>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center