[mythtv-commits] Ticket #9927: [HANG] DeviceReadBuffer leaks threads on error untill backend hangs

[MythTV]

#9927: [HANG] DeviceReadBuffer leaks threads on error untill backend hangs
-------------------------------------------------+-------------------------
 Reporter:  Tony Lill <ajlill@…>                 |          Owner:  danielk
     Type:  Patch - Bug Fix                      |         Status:  new
 Priority:  minor                                |      Milestone:  unknown
Component:  MythTV - Recording                   |        Version:
 Severity:  medium                               |  0.24-fixes
 Keywords:                                       |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by Tony Lill <ajlill@…>):

 Ok, I updated the patch to use a boolean instead of the thread variable.

 I also looked at the code in master. It still suffers from the problem
 that IsRunning tells you if the thread is active, not if it's been created
 and requires reaping to free up the resources. I don't know if the other
 changes to the code make that distinction irrelevant for the issue
 addressed in this bug, but I think it's still a problem.

 I also think that there is potentially another problem in the while loop
 at the end of the Start function. If the ::run starts and exits before
 that loop can see the IsRunning return true, it will be stuck there
 forever.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9927#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center