[mythtv-commits] Ticket #9546: [patch] corrupted read buffer refs #9511

[MythTV]

#9546: [patch] corrupted read buffer refs #9511
-------------------------------------------------+-------------------------
     Reporter:  Jiri Fojtasek <jiri.fojtasek@…>  |      Owner:  janne
         Type:  Patch - Bug Fix                  |     Status:  new
     Priority:  critical                         |  Milestone:  unknown
    Component:  MythTV - Video Playback          |    Version:  Trunk Head
     Severity:  high                             |   Keywords:
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Replying to [comment:15 markk]:
 > Jiri - I'm closing this ticket as fixed, though recognise that there are
 probably outstanding issues.
 >
 > The RingBuffer wait condition should have been resolved in
 c3e1879e0c284b3c2267 and I took a slightly different approach to the
 decoder eof problem in 679b668e3669a38bd08e
 >
 > If you are still seeing issues with livetv hitting the end of the file
 during normal playback, please open another ticket as that is a separate
 issue that needs a proper root cause analysis.
 >
 > Thanks for the time and effort taken in debugging the issue and
 producing the patches.
 >
 > Mark
 Mark,
 c3e1879e0c284b3c2267 introduced new problem and its stream corruption when
 you hit pause/play few times (sometimes leading in to playback crash), or
 during program switch/jump.

 Your solution is wrong because when the buffer is paused and decoder
 trying to read from ringbuffer ReadDirect is used instead and reading data
 from physical file without readahead buffer and read position adjustment.
 This will cause readahead buffer corruption when playback is resumed.

 Attached patch reverting c3e1879e0c284b3c2267 and fixing wait condition by
 another way than in my previous patch.

 Jiri

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9546>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center