[mythtv-commits] Ticket #9971: Improve CrystalHD decoding for BCM 70012
MythTV
noreply at mythtv.org
Mon Aug 8 03:42:25 UTC 2011
#9971: Improve CrystalHD decoding for BCM 70012
---------------------------------+-----------------------------------------
Reporter: czhang1974@… | Type: Patch - Bug Fix
Status: new | Priority: minor
Milestone: unknown | Component: MythTV - Video Decoding
Version: 0.24-fixes | Severity: medium
Keywords: crystalhd | Ticket locked: 0
---------------------------------+-----------------------------------------
This patch fixes the green overlay problem reported in the following
thread on the bcm70012.
http://www.gossamer-threads.com/lists/mythtv/dev/453116
The default output format from CrystalHD on the bcm70012 is NV12, not
YV12. It can be changed to use YV12 by setting some flags if we use the
DtsProcOutput instead of DtsProcOutputNoCopy, but further reading of the
library source code shows that it was converted to YV12 in software
anyways. The hardware output is always in NV12, so there is no gain in
using YV12.
I also had to make sure that the buffer is always released after decoding.
I am still not sure why the code checked for mpa_pic.data[3] before
calling the release_buffer, which effectively blocked the call since that
would always be NULL for the crystalhd decoder. It most likely is breaking
something else that I don't know about, but I will leave that to someone
more familiar with the other private decoders.
This now works reasonably well for 720P on my AppleTV. 1080i is still
having serious stuttering problem that I can't find the root cause of yet.
--
Ticket URL: <http://code.mythtv.org/trac/ticket/9971>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list