[mythtv-commits] Ticket #8733: (insert|update)_dtv_multiplex debug output does not include values being updated

[MythTV]

#8733: (insert|update)_dtv_multiplex debug output does not include values being
updated
-----------------------------------------------------------------+----------
 Reporter:  Nick Morrott <knowledgejunkie (at) gmail (dot) com>  |           Owner:  stuarta   
     Type:  defect                                               |          Status:  closed    
 Priority:  minor                                                |       Milestone:  unknown   
Component:  MythTV - Channel Scanner                             |         Version:  Trunk Head
 Severity:  medium                                               |      Resolution:  fixed     
 Keywords:  channel scanner debug log output                     |   Ticket locked:  0         
-----------------------------------------------------------------+----------

Comment (by Nick Morrott <knowledgejunkie <at> gmail <dot> com>):

 In testing with a debug build of r26195, the update did not fix the issue
 but replaced each bound variable's name with a question mark. First few
 inserts follow:

 {{{
 2010-09-10 08:44:59.348 New DB DataDirect connection
 2010-09-10 08:44:59.349 Connected to database 'mythconverg' at host:
 localhost
 2010-09-10 08:44:59.351 insert_dtv_multiplex(1, 'dvb', 746000000, auto,
 24576, 9018...) mplexid:0
 2010-09-10 08:44:59.352 insert_dtv_multiplex -- insert 0
 INSERT INTO dtv_multiplex   (sourceid,        sistandard,
 frequency,  modulation, transportid, networkid, symbolrate, bandwidth,
 polarity, inversion, transmission_mode, fec, constellation, hierarchy,
 hp_code_rate, lp_code_rate, guard_interval, mod_sys, rolloff) VALUES   (?,
 ?,       ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);

 2010-09-10 08:44:59.352 insert_dtv_multiplex -- inserted 1
 Insert(dvb): 18
 2010-09-10 08:44:59.355 insert_dtv_multiplex(1, 'dvb', 746000000, auto,
 24576, 9018...) mplexid:1
 2010-09-10 08:44:59.356 insert_dtv_multiplex -- update 1
 UPDATE dtv_multiplex SET frequency    = ?, modulation       = ?,
 symbolrate       = ?, bandwidth        = ?, polarity         = ?,
 inversion        = ?, transmission_mode= ?, fec              = ?,
 constellation    = ?, hierarchy        = ?, hp_code_rate     = ?,
 lp_code_rate     = ?, guard_interval   = ?, mod_sys          = ?, rolloff
 = ? WHERE sourceid    = ?      AND       sistandard  = ?    AND
 transportid = ? AND networkid = ?

 Insert(dvb): 21
 2010-09-10 08:44:59.359 insert_dtv_multiplex(1, 'dvb', 746000000, auto,
 24576, 9018...) mplexid:1
 2010-09-10 08:44:59.360 insert_dtv_multiplex -- update 1
 UPDATE dtv_multiplex SET frequency    = ?, modulation       = ?,
 symbolrate       = ?, bandwidth        = ?, polarity         = ?,
 inversion        = ?, transmission_mode= ?, fec              = ?,
 constellation    = ?, hierarchy        = ?, hp_code_rate     = ?,
 lp_code_rate     = ?, guard_interval   = ?, mod_sys          = ?, rolloff
 = ? WHERE sourceid    = ?      AND       sistandard  = ?    AND
 transportid = ? AND networkid = ?

 Insert(dvb): 12
 2010-09-10 08:44:59.363 insert_dtv_multiplex(1, 'dvb', 746000000, auto,
 24576, 9018...) mplexid:1
 2010-09-10 08:44:59.364 insert_dtv_multiplex -- update 1
 UPDATE dtv_multiplex SET frequency    = ?, modulation       = ?,
 symbolrate       = ?, bandwidth        = ?, polarity         = ?,
 inversion        = ?, transmission_mode= ?, fec              = ?,
 constellation    = ?, hierarchy        = ?, hp_code_rate     = ?,
 lp_code_rate     = ?, guard_interval   = ?, mod_sys          = ?, rolloff
 = ? WHERE sourceid    = ?      AND       sistandard  = ?    AND
 transportid = ? AND networkid = ?

 }}}

 On a more general note, why does the log output not include the channel
 data being inserted (which is always different) and instead duplicate the
 same multiplex information a dozen or more times? Would it not be more
 useful to first log the list of muxes being inserted/updated, and then log
 the list of channels being inserted from the scan?

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8733#comment:4>
MythTV <http://www.mythtv.org/>
MythTV Media Center