[mythtv-commits] mythtv commit: r27374 - in trunk/mythtv by mdean

[mythtv at cvs.mythtv.org]

      Author: mdean
        Date: 2010-11-29 23:59:14 +0000 (Mon, 29 Nov 2010)
New Revision: 27374
   Changeset: http://svn.mythtv.org/trac/changeset/27374

Log:

Remove the "LIRC keypress application".

This setting was introduced in [3482] using the patch from http://www.gossamer-threads.com/lists/mythtv/dev/20659#20659 .  All of the functionality provided by the setting can now be achieved without involving MythTV, so this change simply removes the middle man.

Users wanting to run an application on some or all LIRC button presses can do so using LIRC's irexec (i.e. map the same button to prog = mythtv and prog = irexec in your ~/.lircrc), or--even better--using some custom daemon program that performs the desired action (blinking LEDs or playing some audio snippet or whatever) without creating a new process to avoid the delay of executing a new process for each button press.

This approach--not using MythTV for this purpose--has many benefits.  First, the "LIRC keypress application" was executed on every single remote button press /and/ every single repeat received by MythTV (when you held down the button).  By using LIRC to configure the button-press application, you can set different repeat/delay amounts for the "keypress application" and MythTV.  Second, using LIRC to configure the button-press application allows assigning a different application (or no application) to individual buttons--i.e. play different audio for different buttons and don't play audio for some buttons.  Third, it removes a hack from MythTV.  And, since the setting in MythTV--as was implemented until it was removed--requires a frontend restart to reload, the LIRC-based approach adds no extra hardship.

Audio feedback for button presses will need to be implemented properly within MythTV--not just running some command for each button press/repeat--if someone wants such capability inside MythTV.


Modified:

   trunk/mythtv/libs/libmythui/lirc.cpp
   trunk/mythtv/libs/libmythui/lirc.h
   trunk/mythtv/libs/libmythui/mythmainwindow.cpp
   trunk/mythtv/programs/mythfrontend/globalsettings.cpp