[mythtv-commits] Ticket #9227: OSD delete dialog contains different text than Watch Recordings delete dialog

[MythTV]

#9227: OSD delete dialog contains different text than Watch Recordings delete
dialog
------------------------------------------------------------+---------------
 Reporter:  John Veness <John.Veness.mythtv@…>              |           Owner:  kenni     
     Type:  defect                                          |          Status:  accepted  
 Priority:  trivial                                         |       Milestone:  0.25      
Component:  Translations                                    |         Version:  0.24-fixes
 Severity:  low                                             |      Resolution:            
 Keywords:  delete dialog strings                           |   Ticket locked:  0         
------------------------------------------------------------+---------------

Comment (by John Veness <John.Veness.mythtv@…>):

 Although this bug has been taken by someone else, I decided to scratch my
 own itch and have submitted a patch. This modifies
 libs/libmythtv/tv_play.cpp ShowOSDPromptDeleteRecording function so that
 the dialog has the same text as the one in
 programs/mythfrontend/playbackbox.cpp. Some notes about this patch:

 * This is my first ever MythTV patch - please be gentle with me!
 * It has been made against the 0.24-fixes SVN branch. I don't have the
 resources to try trunk
 * It copies and pastes code from mythfrontend to make the subtitle appear
 correctly truncated if necessary
 * I wonder if a better solution would be to put both blocks of code into a
 library somewhere and call the function from both places, rather than
 duplicating code. That's beyond me, though

 Many thanks for considering this patch.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/9227#comment:4>
MythTV <http://www.mythtv.org/>
MythTV Media Center