[mythtv-commits] Ticket #8519: Write FileTransfers not properly closed, prevents shutdown of backend

MythTV mythtv at cvs.mythtv.org
Mon May 31 20:01:45 UTC 2010


#8519: Write FileTransfers not properly closed, prevents shutdown of backend
--------------------------------------------+-------------------------------
 Reporter:  [R] <ginsu.squirrel@…>          |       Owner:  ijr        
     Type:  patch                           |      Status:  new        
 Priority:  minor                           |   Milestone:  unknown    
Component:  MythTV - General                |     Version:  Unspecified
 Severity:  medium                          |     Mlocked:  0          
--------------------------------------------+-------------------------------
 When using the metadata grabber in MythVideo, the FileTransfer sockets
 don't get closed properly and the backend never goes into idle mode.

 The frontend opens RemoteFile connections to write the images to the
 storage group in the backend.  This create FileTransfer objects in the
 backend that don't get properly cleaned up when the transfer finishes.
 When a new writemode FileTransfer object is created, the MythSocket
 callbacks are disabled, which I've been told on IRC was due to the reader
 thread.  But that thread is what properly closes the sockets and removes
 them from the fileTransferList in the MainServer.  When the socket isn't
 removed from the fileTransferList, the backend thinks it still has open
 sockets, and won't go into idle mode and shutdown properly.  The attached
 patch reenables the callbacks when the backend receives the DONE command,
 which allows the reader thread to close the socket and remove it from the
 fileTransferList.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8519>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list