[mythtv-commits] Ticket #8491: Commercial detection runs for commercial-free channels

[MythTV]

#8491: Commercial detection runs for commercial-free channels
------------------------------+---------------------------------------------
 Reporter:  mdean             |       Owner:  ijr       
     Type:  defect            |      Status:  new       
 Priority:  minor             |   Milestone:  unknown   
Component:  MythTV - General  |     Version:  Trunk Head
 Severity:  medium            |     Mlocked:  0         
------------------------------+---------------------------------------------
 Since the ProgramInfo refactor, it seems that we only set FL_CHANCOMMFREE
 in the programflags when reading a RecordingInfo from the DB.  So, when
 init_jobs() ( libs/libmythtv/tv_rec.cpp around line 3901) looks at
 rec->IsCommercialFree(), it always gets false (because the RI was created
 from a PI, not read from the DB).

 From discussion on IRC: "The first thing I'd do is check if we can just
 load those flags in the jobqueue's PI. Alternatively we can pull it from
 the DB with a QueryIsCommercialFree() call."

 (Leaving this at MythTV-General since it's more related to ProgramInfo
 than to mythcommflag.)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8491>
MythTV <http://www.mythtv.org/>
MythTV