[mythtv-commits] mythtv commit: r24767 by stuartm

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Fri May 21 22:44:29 UTC 2010

      Author: stuartm
        Date: 2010-05-21 22:44:29 +0000 (Fri, 21 May 2010)
New Revision: 24767
   Changeset: http://svn.mythtv.org/trac/changeset/24767




Simplfy and improve the handling of star ratings from xmltv. Xmltv allows grabbers to return multiple ratings for a programme, in most cases this will be a reviewer/user star rating out of 5 or 10 and possibly a recommendation which would be represented as 1/1. The comments in the old code implied that multiple ratings were averaged out, but aside from misunderstaning the spec that code was completely broken so it never worked. Instead it always used the last rating described by the xml. The existing behaviour produced some undesired results, a 3/5 star film which happened to be recommended just because it was the only thing worth watching on a given night would appear to MythTV as a top-rated 5/5,10/10 programme even as the description described it as mediocre. So instead we now use the first rating to appear in the xml and ignore the rest, we assume the most important rating appears first. We don't attempt to average as that would only produce mis-leading results reflecting
  not the quality of the programme, but it's quality when compared against other programmes in the schedules at an exact point in time.

More information about the mythtv-commits mailing list