[mythtv-commits] Ticket #8449: job list for mtd

MythTV mythtv at cvs.mythtv.org
Wed May 12 21:27:33 UTC 2010

#8449: job list for mtd
 Reporter:  markeyb@…             |       Owner:  awithers      
     Type:  enhancement           |      Status:  infoneeded_new
 Priority:  minor                 |   Milestone:  unknown       
Component:  Plugin - MythVideo    |     Version:  Trunk Head    
 Severity:  medium                |     Mlocked:  0             
Changes (by robertm):

  * status:  new => infoneeded_new



 There is a *lot* going on in this patch that has nothing to do with the
 patch itself-- line wrapping, random conversational commenting,
 datestamping it with your name, etc.  In order to be able to review this,
 I need to see the functional changes, doxygen commenting of any functions
 you add (see videodlg.cpp for examples of how to properly doxygen
 comment), and none of the extra formatting changes.  For this to have any
 hope of being applied, it really needs to be easier to review.

 Please revise with the following guidelines:

 * No whitespace-only changes.
 * No linewrapping-only changes.
 * No datestamping with your name.
 * No comments added to code that you are not touching.
 * No commenting out existing code.  If it's not usable, remove it, don't
 comment it out.
 * Add doxygen commenting, not ad-hoc commenting
 * Spellcheck comments!  They need to be in grammatically correct english.
 * No first-person commentary.
 * Update dbcheck code to match current schema, this version will not
 * Initialize variables efficiently (int Track, Audio, Quality, AC3;)
 * Yikes, you can't just append to the log forever.  Please remove that.

Ticket URL: <http://svn.mythtv.org/trac/ticket/8449#comment:1>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list