[mythtv-commits] Ticket #8590: Nondeterministic mythcommflag segfaults on trunk
MythTV
mythtv at cvs.mythtv.org
Fri Jun 25 01:47:35 UTC 2010
#8590: Nondeterministic mythcommflag segfaults on trunk
---------------------------------+------------------------------------------
Reporter: km@… | Owner: danielk
Type: defect | Status: assigned
Priority: minor | Milestone: 0.24
Component: MythTV - General | Version: Trunk Head
Severity: medium | Mlocked: 0
---------------------------------+------------------------------------------
Comment(by km@…):
I've tested the obvious fix, and it solves the segment fault problem.
{{{
*** ClassicCommDetector.cpp.orig 2010-06-24 13:53:28.000000000
-0400
--- ClassicCommDetector.cpp 2010-06-24 13:53:49.000000000 -0400
***************
*** 869,881 ****
leftDarkCol = x;
}
- delete[] colMax;
for(int x = commDetectBorder; x < (width - commDetectBorder);
x += horizSpacing)
if (colMax[x] >= commDetectBoxBrightness)
rightDarkCol = x;
if ((topDarkRow > commDetectBorder) &&
(topDarkRow < (height * .20)) &&
(bottomDarkRow < (height - commDetectBorder)) &&
--- 869,882 ----
leftDarkCol = x;
}
for(int x = commDetectBorder; x < (width - commDetectBorder);
x += horizSpacing)
if (colMax[x] >= commDetectBoxBrightness)
rightDarkCol = x;
+ delete[] colMax;
+
if ((topDarkRow > commDetectBorder) &&
(topDarkRow < (height * .20)) &&
(bottomDarkRow < (height - commDetectBorder)) &&
}}}
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8590#comment:6>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list