[mythtv-commits] Ticket #8589: Recordings are nolonger identified as 720p or 1080i/p since the ProgramInfo refactor.

[MythTV]

#8589: Recordings are nolonger identified as 720p or 1080i/p since the ProgramInfo
refactor.
--------------------------------------+-------------------------------------
 Reporter:  MarcT <myrdhn@…>          |       Owner:  danielk   
     Type:  defect                    |      Status:  new       
 Priority:  trivial                   |   Milestone:  unknown   
Component:  MythTV - Recording        |     Version:  Trunk Head
 Severity:  low                       |     Mlocked:  0         
--------------------------------------+-------------------------------------

Comment(by MarcT <myrdhn@…>):

 There is a specific section of code that was removed that in the
 programinfo refactor that never had a similar function added to replace
 the functionality of the removed code.

 This is the section that was removed

      query.prepare("UPDATE recordedprogram SET videoprop ="
      " CONCAT_WS(',', IF(videoprop = '', NULL, videoprop), :VALUE)"
      " WHERE chanid = :CHANID AND starttime = :STARTTIME;");

      if (width > 1300)
      {
          VERBOSE(VB_GENERAL, LOC +
                  QString("Recording designated 1080i/p because width was
 %1")
                  .arg(width));
          videoproperties |= VID_1080;

          query.bindValue(":VALUE", "1080");
          query.bindValue(":CHANID", chanid);
          query.bindValue(":STARTTIME", startts);

          if (!query.exec())
              MythDB::DBError("UpdateRes", query);
      }
      else if (width > 800)
      {
          VERBOSE(VB_GENERAL, LOC +
                  QString("Recording designated 720p because width was %1")
                  .arg(width));
          videoproperties |= VID_720;

          query.bindValue(":VALUE", "720");
          query.bindValue(":CHANID", chanid);
          query.bindValue(":STARTTIME", startts);

          if (!query.exec())
              MythDB::DBError("UpdateRes", query);
      }
      else
      {
          VERBOSE(VB_IMPORTANT, LOC_ERR +
                  QString("Unknown type, recording width was
 %1").arg(width));
          return;
      }

      m_videoWidth = width;

 This is the section that was added.

      query.prepare(
          "UPDATE recordedprogram "
          "SET videoprop = ((videoprop+0) & :OTHERFLAGS) | :FLAGS "
          "WHERE chanid = :CHANID AND starttime = :STARTTIME");

      query.bindValue(":OTHERFLAGS", ~(VID_1080|VID_720));
      query.bindValue(":FLAGS",      vid_flags);
      query.bindValue(":CHANID",     chanid);
      query.bindValue(":STARTTIME",  recstartts);

      uint videoproperties = GetVideoProperties();
      videoproperties &= (uint16_t) ~(VID_1080|VID_720);
      videoproperties |= (uint16_t) vid_flags;
      properties &= ~(0x1F<<6);
      properties |= videoproperties<<6;

 Looking at these it seems that the code to set the value as 720 or 1080
 was removed and no replacement was added.

 Here is a select statement from my database from the recordedprogram table

 select chanid,starttime,title,videoprop from recordedprogram where title
 like 'CSI%' order by starttime;

          +--------+---------------------+------------+-----------+
          | chanid | starttime           | title      | videoprop |
          +--------+---------------------+------------+-----------+
          |   2804 | 2010-05-03 22:01:00 | CSI: Miami | HDTV,1080 |
          |   2804 | 2010-05-05 22:00:00 | CSI: NY    | HDTV,720  |
          |   2804 | 2010-05-10 22:01:00 | CSI: Miami | HDTV,1080 |
          |   2804 | 2010-05-12 22:00:00 | CSI: NY    | HDTV,1080 |
          |   2814 | 2010-05-16 18:00:00 | CSI: Miami | HDTV,1080 |
          |   2814 | 2010-05-16 23:00:00 | CSI: Miami | HDTV      |
          |   2804 | 2010-05-17 22:01:00 | CSI: Miami | HDTV      |
          |   2804 | 2010-05-19 22:00:00 | CSI: NY    | HDTV      |
          |   2814 | 2010-05-23 18:00:00 | CSI: Miami | HDTV      |
          +--------+---------------------+------------+-----------+

 As you can see the 720/1080 is nolonger being sent to the videoprop column
 in the table since the update I did in between the 2 recordings from May
 16th.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8589#comment:1>
MythTV <http://www.mythtv.org/>
MythTV