[mythtv-commits] Ticket #8564: Inserting a new cut point alters existing cut points

MythTV mythtv at cvs.mythtv.org
Mon Jun 21 14:14:13 UTC 2010

#8564: Inserting a new cut point alters existing cut points
 Reporter:  jrlagrone@…        |       Owner:  markk     
     Type:  defect             |      Status:  accepted  
 Priority:  minor              |   Milestone:  unknown   
Component:  MythTV - General   |     Version:  Trunk Head
 Severity:  low                |     Mlocked:  0         

Comment(by Jim Stichnoth <stichnot@…>):

 The attached patch restores the original behavior as far as I can tell.

 1. Fixes the logic error pointed out in the previous comment.

 2. Only calls DeleteMap::CleanMap() after a cutlist is loaded and before
 it is saved.

 3. Doesn't try to clean the deletemap when Add() is called.

 4. This is the tricky part.  In OSD::SetRegions(), convert discontinuities
 (i.e., two marks in a row of the same type) into overlapping cut regions.
 It would probably be cleaner to extend the definition of regions in
 MythUIEditBar to include whether the start point and the end point should
 contain a start/end image, but that would require a lot more than a one-
 line change to MythUIEditBar.

Ticket URL: <http://svn.mythtv.org/trac/ticket/8564#comment:4>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list