[mythtv-commits] mythtv commit: r23202 - in trunk by mdean

[mythtv at cvs.mythtv.org]

      Author: mdean
        Date: 2010-01-19 01:53:02 +0000 (Tue, 19 Jan 2010)
New Revision: 23202
   Changeset: http://svn.mythtv.org/trac/changeset/23202

Modified:

   trunk/mythplugins/mythvideo/mythvideo/dbcheck.cpp
   trunk/mythtv/bindings/python/MythTV/MythDB.py
   trunk/mythtv/libs/libmythtv/dbcheck.cpp

Log:

Fixes #7436.  Remove a couple of duplicate indices.

The recgroup index on the recgrouppassword table was added in [3112] when a named index identical to the primary key index was created during table creation, likely just an oversight.  This duplicate index should exist in all valid mythconverg schemas, and would only be missing if users edited their schemas (which they should never do).

The title_2 index on the videometadata table was added in [2635] as a quick solution to fixing a broken DB upgrade path.  This duplicate index is likely to exist on most mythconverg schemas, but it is possible that it won't exist in some valid mythconverg schemas (that were created long ago) due to the broken DB upgrade path fixed by [2635].

Though neither index caused any harm, they're being removed only for cleanliness of the schema design.  There are no functional changes due to this update.  In all, the end result is that the removal of the recgroup index may save up to 1 kiB and the removal of the title_2 index may save up to 10's of kiB of storage space on the hard drive.

Checking to see if the index exists before removing it simply prevents logging errors that aren't errors and, even if there is an error removing the index, the error is ignored (as the extra indices don't cause any harm) and the schema update is considered complete and successful.