[mythtv-commits] Ticket #7799: mythtv-setup connects to random DBs

[MythTV]

#7799: mythtv-setup connects to random DBs
---------------------------+------------------------------------------------
 Reporter:  danielk        |       Owner:  dblain
     Type:  defect         |      Status:  new   
 Priority:  minor          |   Milestone:  0.23  
Component:  MythTV - UPnP  |     Version:  head  
 Severity:  medium         |     Mlocked:  0     
---------------------------+------------------------------------------------

Comment(by nigel):

 Hmmm. I was probably the last to work on this code, so maybe I should look
 at it, though I need to understand what we want it to do.
 [[BR]]
 MythContextPrivate::FindDatabase() does its best to find a database. It
 currently doesn't care if you have a config file (config.xml or mysql.txt)
 that refers to an invalid host, have a file that points to localhost that
 has no database running, or no file so it assumes localhost. Either way,
 if there is no database listening there, it will start looking 'further
 afield' for something to bind its settings to.
 [[BR]]
 It is easy to make MCP::LoadDatabaseSettings() return a boolean if there
 was a mysql.txt, and exit or put up a warning if we can't bind to its
 database, but config.xml is a different kettle-of-fish. It stores a
 backend's UPnP UID and last database host location. The DBHost in there
 isn't necessarily up to date if a user has reconfigured their network.
 [[BR]]
 Easy enough to pass another boolean into MythContext::Init() for
 MCP::FindDatabase() to use. Something like promptBeforeUPnP,
 warnIfConfigBad or exitIfConfigBad ? My thought is that mythtv-setup needs
 the new behaviour, but mythfrontend and mythwelcome don't (one less
 annoying dialog). Undecided about mythbackend, mythcommflag,  mythjobqueue
 and mythtranscode.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7799#comment:2>
MythTV <http://www.mythtv.org/>
MythTV