[mythtv-commits] Ticket #7890: DVD playback can lock with Waited too long for vide out to unpause

[MythTV]

#7890: DVD playback can lock with Waited too long for vide out to unpause
--------------------------------------------------------+-------------------
 Reporter:  John Harvey <john.p.harvey@…>               |       Owner:  skamithi
     Type:  defect                                      |      Status:  new     
 Priority:  minor                                       |   Milestone:  unknown 
Component:  MythTV - DVD Playback                       |     Version:  unknown 
 Severity:  medium                                      |     Mlocked:  0       
--------------------------------------------------------+-------------------
 When fast forwarding the dvd playback can lock continually printing the
 above message. This is caused by fast forward code doing PauseVideo, FFwf,
 UnPauseVideo. If the FFwd take you to a still frame, while the
 UnpauseVideo is happening the videout thread does a Pause which causes the
 UnPause to never happen.

 The Videout loop checks PauseVideo which is really a request state from
 the decode and thinks we are unpaused when we are still actually paused
 and therefore breaks the request to unpause. Changing this to check the
 actual state (video_actually_paused) fixes this problem.
 I also changed PauseVideo to not set video_actually_paused if we are not
 waiting since i believe this is used so we wait for a frame interval and
 check that it reputs us inot pause state. Since the not waiting is only
 called from the videout loop we dont need to wait for that to happen and
 since we can call that without a lock changing it could break another call
 to UnpauseVideo

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7890>
MythTV <http://www.mythtv.org/>
MythTV