[mythtv-commits] Ticket #7762: Autoshutdown slave feature enhanced

[MythTV]

#7762: Autoshutdown slave feature enhanced
-------------------------------+--------------------------------------------
 Reporter:  gmembre@…          |       Owner:  cpinkham
     Type:  enhancement        |      Status:  assigned
 Priority:  minor              |   Milestone:          
Component:  MythTV - General   |     Version:  unknown 
 Severity:  medium             |     Mlocked:  0       
-------------------------------+--------------------------------------------

Comment(by anonymous):

 Thanks Guillaume,

 I have been through cpinkham's list in detail and see what he's saying.
 I did not understand originally the point about the AllowSlaveToSleep
 setting. That is not present in the original incarnation (as found in
 0.22), so maybe he is saying why introduce a new setting. The logic being,
 if an individual SBE has a sleep command defined, it should not need
 further settings to allow it to sleep. To disable sleep, you ensure the
 SleepCommand for that slave is null. Since you were using HaltCommand
 (which is a global setting) each SBE _did_ need individual permission to
 sleep. That's clear now, so I would say the definition of (in mythtv-
 setup) and the check for AllowSlaveToSleep should both be removed.

 Also I think I accidentally introduced the second call to SendResponse
 when I was adding back cpinkham's detection of the SleepCommand being
 empty.... apologies. (That may be why I had socket error messages in my
 log).

 With the issues resolved, the patch could be accepted :-)  You might not
 get agreement from the devs that the DailyWakeup period should apply to
 SBE's as well..... I think the reasoning would be that the MBE (only)
 should be woken using DailyWakeup and then it would command SBE's to wake
 as-needed via WOL. In a system with many SBE's it may not be desirable for
 all of them to wake up at the same time, if they do not have jobs to
 perform. I was thinking of a patch to get JobQueue to wake a SBE which is
 sleeping and has jobs due, so that would integrate nicely.

 Hope that helps, I look forward to testing a revised patch, Simon.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7762#comment:9>
MythTV <http://www.mythtv.org/>
MythTV