[mythtv-commits] Ticket #8190: NEXTSOURCE Key stops mythfrontend accepting input

[MythTV]

#8190: NEXTSOURCE Key stops mythfrontend accepting input
------------------------------+---------------------------------------------
 Reporter:  Paul              |        Owner:  ijr    
     Type:  defect            |       Status:  closed 
 Priority:  minor             |    Milestone:  unknown
Component:  MythTV - General  |      Version:  0.22   
 Severity:  medium            |   Resolution:  fixed  
  Mlocked:  0                 |  
------------------------------+---------------------------------------------
Changes (by mdean):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [24274]) Fix a deadlock in TV::SwitchSource() that occured when using
 the NEXTSOURCE/PREVSOURCE key bindings to switch sources.

 The code in TV::timerEvent() was holding a lock, causing a deadlock when
 TV::SwitchSource() requested the PlayerContext.  This changes
 TV::SwitchSource() to work like the related TV::SwitchCards() and
 TV::ToggleInputs functions by using the PlayerContext that
 TV::timerEvent() passes through TV::ProcessKeypress() and, finally, to
 TV::ActivePostQHandleAction(), which calls TV::SwitchSource().

 This seems to have been broken in the mythtv-vid branch, but the code was
 unreachable/untestable due to broken key bindings (which were fixed for
 #6472).

 Refs #6472.  Fixes #8190.  Thanks to jafa for finally getting a backtrace.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8190#comment:7>
MythTV <http://www.mythtv.org/>
MythTV