[mythtv-commits] Ticket #8357: add xdg-screensaver support

MythTV mythtv at cvs.mythtv.org
Sat Apr 17 20:13:13 UTC 2010


#8357: add xdg-screensaver support
---------------------------------------------------+------------------------
 Reporter:  Johnny Walker <johnnyjboss@…>          |       Owner:  ijr    
     Type:  enhancement                            |      Status:  new    
 Priority:  minor                                  |   Milestone:  unknown
Component:  MythTV - General                       |     Version:  0.23rc2
 Severity:  low                                    |     Mlocked:  0      
---------------------------------------------------+------------------------

Comment(by Johnny Walker <johnnyjboss@…>):

 My apologies - I knew better on the tabstops and in my eagerness I forgot
 about that.

 This also my excuse/explanation for leaving in my comment re: House.

 I've corrected the tabstops and removed some unneeded items from the
 ScreenSaverXDG class.

 To test I run mythfrontend in a window and "watch -n 1 'xdg-screensaver
 status'" in another and I see that when I enter playback the screensaver
 is reported to be disabled and when I pause it is enabled.

 I feel like the internal variable of m_xdgscreensaverRunning is a
 misleading name - it actually appears to mean that the xdgscreensaver is
 available, and since we instantiated this class we've already determined
 that xdg-screensaver is available. I'm tempted to rename or remove that
 variable and the checks of it in the disable and restore methods. I left
 it as it to match the naming in the screensaver-x11 class that I copied to
 create this one.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8357#comment:1>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list