[mythtv-commits] Ticket #7293: win32-packager.pl updates and cleanup

MythTV mythtv at cvs.mythtv.org
Mon Oct 12 08:03:54 UTC 2009

#7293: win32-packager.pl updates and cleanup
 Reporter:  Jeff Lu <jll544 at yahoo.com>  |        Owner:  nigel  
     Type:  patch                       |       Status:  new    
 Priority:  minor                       |    Milestone:  unknown
Component:  Ports - Windows             |      Version:  head   
 Severity:  medium                      |   Resolution:         
  Mlocked:  0                           |  

Comment(by Jonathan Martens <jonathan at snetram.nl>):

 Replying to [comment:4 davidbuzz at gmail.com]:
 > Jeff ( and others ) , the 'make_clean.sh' script is over-zealous in it's
 clean-up, and it's designed specifically to over-clean rather than under-
 clean, as a longer build time is safer than a borked dll or package,
 especially during development.  If you tweak it, please be sure to keep
 the existing "zeal", or you're risk of re-introducing build bugs is high.
 Buzz.  :-)

 I am not sure it should be so over-zealous as on the other OS-es a make
 (dist)clean should be enough. Why would we want to do extra on Windows?

 IMHO it should work with make (dist)clean and if it does not there is
 something we need to fix, instead of work around.

 In my experience the build process is pretty neat and the make (dist)clean
 process removes a lot (if not all) files that you try and manually find in
 order to delete, others are overwritten on each build and should therefore
 need no action.

 Make is designed to do what it needs to do and clean what it needs to
 clean, so the over-zealousness is more a pain in the ... than a precaution
 in preventing issues.
 The same holds for the cleanup (removes local changes and patches applied
 in the tree, so you will have to hack them into win32-packager.pl which
 makes testing patches harder) and switch commands which are not needed as
 we build from trunk after this patch anyhow.

Ticket URL: <http://svn.mythtv.org/trac/ticket/7293#comment:5>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list