[mythtv-commits] Ticket #7614: Segfault can occur in TVRec::StartRecording()

[MythTV]

#7614: Segfault can occur in TVRec::StartRecording()
------------------------------------+---------------------------------------
 Reporter:  david.madsen@…          |        Owner:  danielk
     Type:  defect                  |       Status:  closed 
 Priority:  minor                   |    Milestone:  unknown
Component:  MythTV - Recording      |      Version:  head   
 Severity:  medium                  |   Resolution:  fixed  
  Mlocked:  0                       |  
------------------------------------+---------------------------------------

Comment(by anonymous):

 Do we need to update the value of cancelNext after updating the iterator?
 If not it may not match the value from the new pending recording.  That
 seems like it would be bad:


 {{{
      // Rescan pending recordings since the event loop may have deleted
      // a stale entry.  If this happens the info pointer will not be valid
      // since the HandlePendingRecordings loop will have deleted it.
      it = pendingRecordings.find(cardid);
 +    if (it != pendingRecordings.end())
 +        cancelNext = (*it).canceled;

 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7614#comment:3>
MythTV <http://www.mythtv.org/>
MythTV