[mythtv-commits] Ticket #7515: SRT subtitle timings wildly variable

[MythTV]

#7515: SRT subtitle timings wildly variable
-------------------------------------+--------------------------------------
 Reporter:  tim@…                    |       Owner:  janne  
     Type:  defect                   |      Status:  new    
 Priority:  minor                    |   Milestone:  unknown
Component:  MythTV - Video Playback  |     Version:  unknown
 Severity:  medium                   |     Mlocked:  0      
-------------------------------------+--------------------------------------
 Trunk, revision 22760.

 When playing a video file with accompanying SRT subtitles, the subtitle
 timings are wildly variable. This is not apparent when comparing the
 subtitle timecodes with the time displayed in myth when pausing, because
 what is causing this problem is that the time displayed in myth is wrong,
 having been calculated from an apparent fps which seems to be wandering
 all over the place (because of A/V sync corrections). Note the video in
 all these cases plays perfectly; no stutter, not too fast, not too slow,
 so whatever the A/V sync is doing, it's obviously working :-)

 The attached patch fixes the problem for me, and puts the subtitles right
 back on the nail of where they're supposed to be.

 It's quite possible there are unintended side effects since as far as I
 can work out currentFrame->timecode is a long long whose size is therefore
 not guaranteed, and it might wrap, but most of the time it's going to be
 pretty big and not too many people watch movies many days long :-)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7515>
MythTV <http://www.mythtv.org/>
MythTV