[mythtv-commits] Ticket #6478: Add update timestamp to program table for incremental program data retrieval

[MythTV]

#6478: Add update timestamp to program table for incremental program data
retrieval
---------------------------------------+------------------------------------
 Reporter:  chasedouglas at gmail.com     |        Owner:  danielk   
     Type:  patch                      |       Status:  infoneeded
 Priority:  minor                      |    Milestone:  unknown   
Component:  MythTV - Mythfilldatabase  |      Version:  head      
 Severity:  medium                     |   Resolution:            
  Mlocked:  0                          |  
---------------------------------------+------------------------------------

Comment(by chasedouglas at gmail.com):

 Replying to [comment:8 danielk]:
 > Replying to [comment:7 anonymous]:
 > > There are three queries prepared in datadirect.cpp, and all three are
 executed. If they weren't it wouldn't work right at all.
 >
 > Right, that's why I want you to look at it. See line 885, that query is
 prepared but not executed.

 The last patch I attached must not be what I'm currently running. I'll try
 to recreate it and attach it again.

 > > What file is missing?
 >
 > listingsources.h, just try applying your patch to virgin sources gcc
 will report missing files.

 I'll make sure it's in the new patch.

 > I think you misunderstood my question. You changed clearDataByChannel()
 to not delete some of the program information by default. I see two things
 wrong with this: First, when you add an argument to a function that has a
 default it should always default to the old behavior to avoid introducing
 bugs and to lessen the effort needed in code review. Second, the
 information in programrating, credits and programgenres is tied to the
 information in program, if you delete an row in one or more of them it
 stands to reason you should delete the matched rows in all the others
 (unless you can explain why that wouldn't be the case?)

 I understand now. The reason I changed the default behavior was that
 DataDirect was the only code path that invoked the function. I mostly
 added the extra argument in case some future code wanted to use the
 functionality. It could be completely stripped out if that would be
 preferred.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6478#comment:9>
MythTV <http://www.mythtv.org/>
MythTV