[mythtv-commits] Ticket #6406: Recordings player picks wrong decuder due to mpegps_probe bug

[MythTV]

#6406: Recordings player picks wrong decuder due to mpegps_probe bug
---------------------------------------------------+------------------------
 Reporter:  Josh Mastronarde <jmastron at gmail.com>  |       Owner:  ijr       
     Type:  patch                                  |      Status:  new       
 Priority:  minor                                  |   Milestone:  unknown   
Component:  MythTV - General                       |     Version:  0.21-fixes
 Severity:  medium                                 |     Mlocked:  0         
---------------------------------------------------+------------------------
 The probe scores reported by the "mpegps" AVFormat decoder are too high
 for either transcoded h.264 mp4 files (which should be handled by the
 "mov,..." decoder, or mpegTS files from an HDHomerun (which should be
 handled by the "mpegts" decoder).  The proper decoder reports a non-zero
 score also, but the mpegps score is higher.  This results in the player
 selecting mpegps, which then fails (bouncing back to the Watch Recordings
 screen).  It appears that mpegps is removed from the encoder list when it
 fails, so the second time the recording plays with the proper decoder.
 However, after that, regular mpegps files (in my case from a PVR150) fail
 to play until the frontend is restarted.

 I believe this was also causing other instability in my system (occasional
 long delays starting to play a show, long delays in processing lirc
 keypresses).  I suspect either the mpegts player can sort of decode
 mpegps, or vice versa, but not properly.  In any case, all of those issues
 seem to have gone away when I patched this.

 The latest ffmpeg sources have a rewritten mpegps_probe procedure that's
 otherwise compatible with the rest of the code.  Trunk already has this as
 of the latest ffmpeg sync.  This patch applies only the "mpegps_probe"
 procedure from the latest ffmpeg code to the 0.21-fixes mpeg.ps.

 I'm submitting because I suspect others may have this issue and not
 realize it (I originally thought my h.264 transcodes were bad, and that my
 HDHomerun wasn't installed properly, until I dug into the code to track it
 down).  Others on mythtv-users report similar symptoms, and logging with
 "-v libav" show the probes being done over and over after this failure.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6406>
MythTV <http://www.mythtv.org/>
MythTV