[mythtv-commits] Ticket #6314: PID filtering of data streams is broken

MythTV mythtv at cvs.mythtv.org
Sun Mar 8 16:01:31 UTC 2009

#6314: PID filtering of data streams is broken
 Reporter:  stuartm            |        Owner:  danielk
     Type:  defect             |       Status:  new    
 Priority:  critical           |    Milestone:  0.22   
Component:  MythTV - DVB/ATSC  |      Version:  head   
 Severity:  medium             |   Resolution:         
  Mlocked:  0                  |  

Comment(by gnome42):

 Hi gbee & Daniel,

 The MPEGStreamData::_recording_type is being set correctly but then it is
 reset back to its default value of "all" by MPEGStreamData::Reset() called
 via other methods such as sm->SetDVBService(netid, tsid, progNum).

 One option for fixing this is to reorder things and always ensure that the
 recording_type is set after Reset() is called. However, a better option is
 to not reset the _recording_type to "all" in Reset(). recording_type is a
 property of the recording profile and does not need to be reset at every
 stream data reset.

 It looks like the "Audio Only" option also suffers from the same problem
 will record from the data pids.

 Attached is a proposed patch to fix both issues. Untested :)

Ticket URL: <http://svn.mythtv.org/trac/ticket/6314#comment:1>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list