[mythtv-commits] Ticket #6118: Mythwelcome / myth context creates multiple identical popups

[MythTV]

#6118: Mythwelcome / myth context creates multiple identical popups
----------------------------------+-----------------------------------------
 Reporter:  otto at kolsi dot fi  |        Owner:  ijr    
     Type:  defect                |       Status:  new    
 Priority:  minor                 |    Milestone:  unknown
Component:  mythtv                |      Version:  head   
 Severity:  low                   |   Resolution:         
  Mlocked:  0                     |  
----------------------------------+-----------------------------------------

Comment(by nigel):

 If no-one beats be to it, something like this should prevent it:
 {{{
 Index: mythdialogbox.cpp
 ===================================================================
 --- mythdialogbox.cpp   (revision 19600)
 +++ mythdialogbox.cpp   (working copy)
 @@ -278,9 +278,9 @@
  void ShowOkPopup(const QString &message, QObject *parent,
                   const char *slot, bool showCancel)
  {
 -    QString                  LOC = "ShowOkPopup('" + message + "') - ";
 -    MythConfirmationDialog  *pop;
 -    static MythScreenStack  *stk = NULL;
 +    QString                         LOC = "ShowOkPopup('" + message + "')
 - ";
 +    static MythConfirmationDialog  *pop = NULL;
 +    static MythScreenStack         *stk = NULL;


      if (!stk)
 @@ -303,6 +303,10 @@
          }
      }

 +    // Prevent multiple popups from being all stacked
 +    if (pop)
 +        stk->PopScreen(pop);
 +
      pop = new MythConfirmationDialog(stk, message, showCancel);
      if (pop->Create())
      {
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6118#comment:1>
MythTV <http://www.mythtv.org/>
MythTV