[mythtv-commits] Ticket #7778: Up and down scrolling directions are reversed in MythGallery

[MythTV]

#7778: Up and down scrolling directions are reversed in MythGallery
----------------------------------------------+-----------------------------
 Reporter:  Clayton Smith <argilo@…>          |       Owner:  ijr    
     Type:  patch                             |      Status:  new    
 Priority:  minor                             |   Milestone:  unknown
Component:  Plugin - MythGallery              |     Version:  head   
 Severity:  medium                            |     Mlocked:  0      
----------------------------------------------+-----------------------------

Comment(by mdean):

 The scrolling seems to work as designed (and as originally implemented in
 [1735] ).  The bindings used are "SCROLLUP" (with help text, "Scroll image
 up," and default binding of 2) and "SCROLLDOWN" (with help text, "Scroll
 image down," and default binding of 8).  When you use the SCROLLUP binding
 (2), the /image/ is moved up while the viewport remains fixed, so you see
 a portion of the image lower than the portion you were seeing.  Similarly,
 when you use the SCROLLDOWN binding (8), the image is moved down while the
 viewport remains fixed, so you see a portion of the image higher than the
 portion you were seeing.

 It seems to have been designed to work intuitively as the numbers are
 arranged on a numeric keypad--where most keypads have a down arrow on 2
 (which is SCROLLUP/moves the image up so you see a lower part of the
 image) and an up arrow on 8 (which is SCROLLDOWN/moves the image down so
 you see a higher part of the image).  Whether we should now (after how
 many versions?) change SCROLLUP and SCROLLDOWN to work as the numbers are
 arranged on a remote control or leave it as it is so that it works as the
 numbers are arranged on a numeric keypad, I'll leave up to someone else.

 My preference, however, would be to completely get rid of the SCROLLUP,
 SCROLLDOWN, SCROLLLEFT, and SCROLLRIGHT bindings used /only/ by
 MythGallery and change the plugin to use the global UP, DOWN, LEFT, and
 RIGHT bindings used everywhere else in Myth--where UP would scroll the
 viewport up (so you see a higher portion of the picture) and DOWN would
 scroll the viewport down (so you see a lower portion of the picture).
 Using the global directional keybindings works well for *both* keyboards
 and remotes (and would work fine for a remote without arrows if the user
 overrides the global bindings for the directional keys in the Gallery
 context to use numbers as now).  I have a patch in the works that would
 allow users to add a new keybinding to a context using MythControls--
 effectively allowing users to override bindings in lower contexts with the
 GUI keybinding editor instead of direct DB editing.

 I'd be happy to make such a patch (and the required DB update).  If we
 take the approach of using the global bindings, I recommend that we leave
 the SCROLLUP/SCROLLDOWN default bindings as they are in 0.22-fixes, and
 users who want to "flip" them for easy remote use should simply remap them
 in MythControls.  Then, when they upgrade to 0.23 (or trunk after the
 change to the global bindings), they'll simply switch to using the global
 directional bindings.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7778#comment:1>
MythTV <http://www.mythtv.org/>
MythTV