[mythtv-commits] Ticket #7638: DVD: wrong audio track selected when switching

MythTV mythtv at cvs.mythtv.org
Sat Dec 5 19:16:53 UTC 2009

#7638: DVD: wrong audio track selected when switching
 Reporter:  linux@…                 |       Owner:  skamithi
     Type:  defect                  |      Status:  accepted
 Priority:  minor                   |   Milestone:  unknown 
Component:  MythTV - General        |     Version:  unknown 
 Severity:  medium                  |     Mlocked:  0       

Comment(by linux@…):


 dvd-audio-stream-ordering-v2.patch does not work for me, namely because
 dvdnav_get_audio_logical_stream does not work as expected. If you feed it
 the stream id the output will always be -1 (from looking at the code I
 guess it only maps some internal numbers as the input stream id must be <=
 8 to get anything besides -1). So in fact your patch will behave exactly
 as before my original patch as dvd_track_num will always be set to -1.

 In my second patch (dvd-audio-stream-ordering.dpatch) I have actually put
 the functionality that one thinks dvdnav_get_audio_logical_stream provides
 in the function dvd_get_logical_audio_stream_id. It will map the stream
 ids to their logical track nos (the disc I am always having problems with
 has a mix of AC3 and DTS tracks and the problem is that the AC3 tracks
 have a stream id range between 128 and 135 while DTS tracks start a 136;
 so in my example, the second logical track has stream id 137 which used to
 be put at the end of the track map by simple sorting).

 I personally think that providing the dvd-specific comparator for the
 sorting a simpler solution now as it keeps irrelevant dvd-specific stuff
 out of StreamInfo and its operator which seems to be a more generic
 structure. The sorting only happens in the DVD case anyway so having a DVD
 specific comparator should not be a problem.

 As a sidenote, I was also wondering of whether the helper functions I
 added belong into avformatdecoder.cpp or DVDRingbuffer.h and it should be
 no problem to move them there.

 Best wishes,


Ticket URL: <http://svn.mythtv.org/trac/ticket/7638#comment:6>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list