[mythtv-commits] Ticket #6391: New deinterlacer for perfect image quality when using an interlaced display mode that matches the source

[MythTV]

#6391: New deinterlacer for perfect image quality when using an interlaced display
mode that matches the source
-------------------------------------+--------------------------------------
 Reporter:  mythtv at glidos.net        |        Owner:  ijr    
     Type:  enhancement              |       Status:  closed 
 Priority:  minor                    |    Milestone:  unknown
Component:  MythTV - Video Playback  |      Version:  unknown
 Severity:  medium                   |   Resolution:  fixed  
  Mlocked:  0                        |  
-------------------------------------+--------------------------------------

Comment(by Tom Dexter <digitalaudiorock at gmail.com>):

 As discussed in this thread:

 http://www.gossamer-threads.com/lists/mythtv/users/378711#378711

 I've been testing the vanilla 0.21-fixes version of this patch with 1080i.
 I was having some very strange motion problems with that version on NBC
 shows where they mix progressive frames in the 1080i content.  I didn't
 have these problems with the original patch that was inadvertently doing
 nothing with bottom field first frames.  I believe my problems were being
 caused by progressive frames being treated as bottom field first due to
 the top_field_first defaulting to zero.

 I'm not sure this fix is valid in all cases (a lot of this video stuff is
 a bit out of my league), but it's worked great in my case:  In the call to
 filter_func within FieldorderDeint, I changed the tff parameter to default
 to 1 in the case of non-interlaced frames.  In the 0.21-fixes version it
 looks like this:


 {{{
     filter_func(
         filter, frame->buf, frame->offsets, frame->pitches,
         frame->width, frame->height, dirty, frame->top_field_first |
 !frame->interlaced_frame,
         dirty);
 }}}

 Again, I'm not sure if there's anything wrong with that.  When no
 progressive frames are mixed with the interlaced content however, it
 should have no affect.

 I'm going to continue testing with that but for so far it's worked
 perfectly.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6391#comment:7>
MythTV <http://www.mythtv.org/>
MythTV