[mythtv-commits] Ticket #5681: resubmission of libmythtv dead code patch

MythTV mythtv at cvs.mythtv.org
Fri Sep 5 22:21:44 UTC 2008

#5681: resubmission of libmythtv dead code patch
 Reporter:  Erik Hovland <erik at hovland.org>  |       Owner:  ijr    
     Type:  defect                           |      Status:  new    
 Priority:  trivial                          |   Milestone:  unknown
Component:  mythtv                           |     Version:  head   
 Severity:  low                              |     Mlocked:  0      
 The top of this patch is the most interesting. The first in startPlaying -
 I expand the commented out code since the meat of the code is already
 commented out. The idea is that it shouldn't have to do that preparation
 code since it won't be used.

 Then in DisplayDVDButton the if clause after the subtitles call is a
 little wonky. The second check of osdshown is unnecessary.

 The next interesting bit is the unnecessary assignment in dsmc.cpp in
 ProcessSection. Everything else has been seen before. But they all are
 related to code that cannot execute.

Ticket URL: <http://svn.mythtv.org/trac/ticket/5681>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list