[mythtv-commits] Ticket #5896: More PHP web page display errors

MythTV mythtv at cvs.mythtv.org
Mon Nov 10 00:24:36 UTC 2008

#5896: More PHP web page display errors
 Reporter:  dhighley at highley-recommended.com  |        Owner:  xris          
     Type:  defect                            |       Status:  infoneeded_new
 Priority:  minor                             |    Milestone:  unknown       
Component:  mythweb                           |      Version:  head          
 Severity:  medium                            |   Resolution:                
  Mlocked:  0                                 |  

Comment(by sphery <mtdean at thirdcontact.com>):

 The patch mythtv-5896-allow_NIS_format_etc_timezone.patch adds a new
 function parse_zone_id_config_string() that parses the value read from
 /etc/timezone or /etc/sysconfig/clock to ensure the value used is a valid
 time zone ID in the zoneinfo database.  This allows us to identify the
 time zone for users with NIS-format /etc/timezone files, which use the

 [zone id] [host or NIS domain name] # optional comments

 as opposed to the Debian-format /etc/timezone which contains only the zone

 Since whitespace may exist in the zone ID and the only delimiter between
 the zone ID and the NIS host/domain name is whitespace,
 parse_zone_id_config_string() just checks for a file in the zoneinfo DB
 whose name corresponds to the parsed value.  If not found, it removes one
 word from the right of the string and tries again until it either finds a
 file or runs out of string.

 The patch also modifies the regexp used in read_time_zone_id() to allow a
 hash/pound character in the line to begin a comment and ensures the
 comment is ignored.  Also, whereas read_time_zone_id() used to blindly
 accept the value it read as a time zone ID, the new conditional (in the
 3rd hunk) requires that the value correspond to a valid zone ID in the
 database, otherwise, we continue searching for the time zone ID.

Ticket URL: <http://svn.mythtv.org/trac/ticket/5896#comment:3>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list