[mythtv-commits] Ticket #5883: Error in MythUIButtonList::RemoveItem() logic

[MythTV]

#5883: Error in MythUIButtonList::RemoveItem() logic
----------------------------------------------+-----------------------------
 Reporter:  Marc Alban <marcalban at gmail.com>  |       Owner:  ijr 
     Type:  defect                            |      Status:  new 
 Priority:  minor                             |   Milestone:  0.22
Component:  mythtv                            |     Version:  head
 Severity:  medium                            |     Mlocked:  0   
----------------------------------------------+-----------------------------
 Removing the top item from a mythui button list results in the list
 scrolling up one space to far.

 When removing an item from the top of a list, the m_topPosition variable
 should not be incremented.

 Consider the case where the top item is at index 0.   If it is removed all
 of the items below it will be shifted up, so the new m_topPosition should
 still be 0, not 1.

 A similar argument is true for m_selPosition when removing an item that is
 currently selected.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5883>
MythTV <http://www.mythtv.org/>
MythTV